Your message dated Sat, 21 Jan 2006 11:47:30 -0800 with message-id <[EMAIL PROTECTED]> and subject line Bug#343669: fixed in tlf 0.9.27-1 has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database) -------------------------------------- Received: (at submit) by bugs.debian.org; 17 Dec 2005 01:25:03 +0000 >From [EMAIL PROTECTED] Fri Dec 16 17:25:03 2005 Return-path: <[EMAIL PROTECTED]> Received: from cassarossa.samfundet.no ([129.241.93.19] ident=Debian-exim) by spohr.debian.org with esmtp (Exim 4.50) id 1EnQop-0004PQ-8X for [EMAIL PROTECTED]; Fri, 16 Dec 2005 17:25:03 -0800 Received: from trofast.ipv6.sesse.net ([2001:700:300:dc03:20e:cff:fe36:a766] helo=trofast.sesse.net) by cassarossa.samfundet.no with esmtp (Exim 4.50) id 1EnQon-0004hG-IX; Sat, 17 Dec 2005 02:25:01 +0100 Received: from sesse by trofast.sesse.net with local (Exim 3.36 #1 (Debian)) id 1EnQon-0002EQ-00; Sat, 17 Dec 2005 02:25:01 +0100 Content-Type: multipart/mixed; boundary="===============3631741400121579979==" MIME-Version: 1.0 From: "Steinar H. Gunderson" <[EMAIL PROTECTED]> To: Debian Bug Tracking System <[EMAIL PROTECTED]> Subject: tlf: several valgrind hits at startup (may result in crash) Message-ID: <[EMAIL PROTECTED]> X-Mailer: reportbug 3.18 Date: Sat, 17 Dec 2005 02:25:01 +0100 X-Spam-Score: -0.0 (/) Delivered-To: [EMAIL PROTECTED] X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 (1.212-2003-09-23-exp) on spohr.debian.org X-Spam-Level: X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE autolearn=no version=2.60-bugs.debian.org_2005_01_02 This is a multi-part MIME message sent by reportbug. --===============3631741400121579979== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline Package: tlf Version: 0.9.25-1 Severity: important Tags: patch Hi, tlf has several valgrind hits, mostly going outside its buffers or reading uninitialized data. This seems to make it crash in some situations and on some machines. The included patch should fix at least the ones during startup. -- System Information: Debian Release: testing/unstable APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.14 Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8) Versions of packages tlf depends on: ii hamlib3 1.2.4-3 Run-time library to control radio ii libc6 2.3.5-8.1 GNU C Library: Shared libraries an ii libncurses5 5.5-1 Shared libraries for terminal hand Versions of packages tlf recommends: ii cwdaemon 0.9.2 morse daemon for the parallel or s -- debconf-show failed --===============3631741400121579979== Content-Type: text/x-c; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="tlf-fix-valgrind-hits.diff" diff -ur tlf-0.9.25/src/parse_logcfg.c tlf-0.9.25.patched/src/parse_logcfg.c --- tlf-0.9.25/src/parse_logcfg.c 2005-11-15 14:43:03.000000000 +0100 +++ tlf-0.9.25.patched/src/parse_logcfg.c 2005-12-17 02:21:33.000000000 +0100 @@ -406,7 +406,7 @@ char *tk_ptr; - for (ii = 0; ii <= MAX_COMMANDS; ii++) { + for (ii = 0; ii < MAX_COMMANDS; ii++) { teststring[0] = '\0'; strncat(teststring, commands[ii], 79); diff -ur tlf-0.9.25/src/readctydata.c tlf-0.9.25.patched/src/readctydata.c --- tlf-0.9.25/src/readctydata.c 2005-11-15 14:43:03.000000000 +0100 +++ tlf-0.9.25.patched/src/readctydata.c 2005-12-17 02:19:29.000000000 +0100 @@ -77,7 +77,9 @@ while ( !feof(fp_db)) { // fgets (buf, 180, fp_db); ### bug fix - fgets (buf, sizeof(buf), fp_db); + if (fgets (buf, sizeof(buf), fp_db) == NULL) { + break; + } if (buf[0] == '\n') continue; @@ -88,6 +90,7 @@ else // prefix line { strncpy(buffer, buf, 79); + buffer[79] = 0; char *loc = NULL; //PG4I, 26Jul2005 if ((loc = strchr(buffer, '\r'))) @@ -104,6 +107,9 @@ buffer[i] = '\0'; } + if (j < 4) + continue; + j = 4; while (strcmp(buffer+j , "") != 0) --===============3631741400121579979==-- --------------------------------------- Received: (at 343669-close) by bugs.debian.org; 21 Jan 2006 19:51:04 +0000 >From [EMAIL PROTECTED] Sat Jan 21 11:51:04 2006 Return-path: <[EMAIL PROTECTED]> Received: from katie by spohr.debian.org with local (Exim 4.50) id 1F0Ohu-0001jW-HY; Sat, 21 Jan 2006 11:47:30 -0800 From: Joop Stakenborg <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] X-Katie: $Revision: 1.65 $ Subject: Bug#343669: fixed in tlf 0.9.27-1 Message-Id: <[EMAIL PROTECTED]> Sender: Archive Administrator <[EMAIL PROTECTED]> Date: Sat, 21 Jan 2006 11:47:30 -0800 X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 (1.212-2003-09-23-exp) on spohr.debian.org X-Spam-Level: X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER autolearn=no version=2.60-bugs.debian.org_2005_01_02 Source: tlf Source-Version: 0.9.27-1 We believe that the bug you reported is fixed in the latest version of tlf, which is due to be installed in the Debian FTP archive: tlf_0.9.27-1.diff.gz to pool/main/t/tlf/tlf_0.9.27-1.diff.gz tlf_0.9.27-1.dsc to pool/main/t/tlf/tlf_0.9.27-1.dsc tlf_0.9.27-1_i386.deb to pool/main/t/tlf/tlf_0.9.27-1_i386.deb tlf_0.9.27.orig.tar.gz to pool/main/t/tlf/tlf_0.9.27.orig.tar.gz A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Joop Stakenborg <[EMAIL PROTECTED]> (supplier of updated tlf package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.7 Date: Sat, 21 Jan 2006 20:36:14 +0100 Source: tlf Binary: tlf Architecture: source i386 Version: 0.9.27-1 Distribution: unstable Urgency: low Maintainer: Joop Stakenborg <[EMAIL PROTECTED]> Changed-By: Joop Stakenborg <[EMAIL PROTECTED]> Description: tlf - Console mode purpose CW keyer, logging- and contest program Closes: 343669 Changes: tlf (0.9.27-1) unstable; urgency=low . * New upstream release. Closes: 343669. Files: 9bf643aa20d2da8dbcce0ff68844c898 616 hamradio optional tlf_0.9.27-1.dsc bf04c65b64db107bf067ddcb4e7d8bb0 388997 hamradio optional tlf_0.9.27.orig.tar.gz 38fe2ad909849aec8e657e588fd53c4d 20939 hamradio optional tlf_0.9.27-1.diff.gz d592441fb2b54050d5ea4b8e32e3787d 261526 hamradio optional tlf_0.9.27-1_i386.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iD8DBQFD0o36/CqtjGLxpX8RApsGAJ45HOlZRTXW881R/qDNJlNAMuQ2KgCfez/y in7fHA1RxPwMBW7pQtrA3BY= =Jz2y -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]