On Sa, 2013-11-02 at 18:40 +0100, Rafael Laboissiere wrote: > * Benjamin Drung <bdr...@debian.org> [2013-11-02 13:08]: > > > On Sa, 2013-11-02 at 12:03 +0100, Rafael Laboissiere wrote: > >> * Benjamin Drung <bdr...@debian.org> [2013-11-02 00:05]: > >>> > >>> I have just one recommendation/wish: It would be nice if test cases > >>> could be added for the new feature. The test cases should work offline. > >> > >> Would something along the lines of the very simple-minded shell script > >> attached below be appropriate? Of course, it will need adaptation for > >> the shunit2 framework used in devscripts. > > > > Yes, that's exactly what I hoped for. We already have test/test_uscan, > > which contains one online test. This could be converted to an offline > > test with your test framework. > > > >> What this script does is (1) create a minimal Debian package directory, > >> containing minimal files debian/{changelog,watch,copyright}, (2) create a > >> minimal repository, containing a tarball (built on the fly), and (3) > >> start an HTTP server that works offline, using the SimpleHTTPServer > >> module of Python. > > > > Maybe this short description could be added to the test case as comment > > (for documentation). > > Ok, I did it and also changed test/Makefile accordingly. The patch is > attached below. Note that I also added an entry in debian/copyright, but > that may be wrong. There is no need to build-depend on libpython-stdlib > (for the SimpleHTTPServer module), because python3-all pulls it in. This > patch works here inside my pbuilder.
The modification on debian/copyright is okay. I have some comments: 1) I like to have one test file for each script which contains one or more tests. So the test file for uscan should be called test_uscan and contain a test function testFileExclusion using shunit. 2) The test in test_uscan should be converted to an offline test or test_uscan should be renamed to test_uscan_online. 3) The test could do more validity checks. It could compare the list of files in the tarball with the expected content. -- Benjamin Drung Debian & Ubuntu Developer -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org