On Thu, 17 Nov 2005, Gerrit Pape wrote:

> Hi Cristian,

Gerrit,

> On Sun, Oct 30, 2005 at 02:16:01AM +0100, Cristian Ionescu-Idbohrn wrote:
> >   * Added option '-t' (time stamp); socklog.c modified.
>
> What is this for?  The timestamp normally is added by the logger
> process, usually the svlogd program.  Can you tell me a use case where
> this is needed?

Yes. I run socklog from the command line and use it to watch the
syslog activity of an embeded system under development. In some cases,
timing is important.

> >   * killed some compilation warnings in socklog.c, chkshsgr.c, seek_set.c;
> >     some more left in pathexec_run.c, pathexec.h, prot.c.
>
> I don't want to change this.  The code and compilation is tested on many
> Unix systems, not only Linux, and was proven to be very portable the way
> it is.

I see. Well, I don't like compilation warnings, that was my reason.

> >   * debian/rules applies patches.
>
> I usually use a construct like this:
>
>         for i in `ls -t debian/diff/*.diff || :`; do \
>           (cd admin/socklog && patch -p0) <$$i || exit 1; \
>         done

Fine with me.

> You then simply put patches into debian/diff/ with a .diff extension.
> But I don't think we need that for socklog, as I'm upstream too, and the
> project is quite mature and stable.

Of course.

> >   * debian/rules builds with debug too.
>
> I'll apply this.


Cheers,
Cristian


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to