Control: submitter -1 !
Control: found -1 git-buildpackage/0.8.18

On 11-Aug-2017, Guido Günther wrote:

> […] what you can do right now is call the clean command as prebuild
> hook since it gets the build_dir passed in as GBP_BUILD_DIR and is
> run right before the build.

Would calling the clean as a pre-build hook prevent Git-BuildPackage
from issuing a clean *before* building the source? Is there some
existing hook that I should disable?

As best I can tell, there is no request for “clean” prior to exporting
the source. Yet it happens in response to a request to build the
source:

=====
$ gbp --version
gbp 0.8.18

$ gbp buildpackage --git-overlay --git-cleaner=/bin/true
gbp:info: All Orig tarballs 'pelican_3.7.1.orig.tar.gz' found at '../tarballs'
gbp:info: Building with (cowbuilder) for sid
gbp:info: Extracting pelican_3.7.1.orig.tar.gz to 
'/home/bignose/Projects/debian/pelican/build-area/pelican-tmp'
gbp:info: Exporting 'WC' to 
'/home/bignose/Projects/debian/pelican/build-area/pelican-tmp'
gbp:info: Moving '/home/bignose/Projects/debian/pelican/build-area/pelican-tmp' 
to '/home/bignose/Projects/debian/pelican/build-area/pelican-3.7.1'
Building with cowbuilder for distribution sid
I: using cowbuilder as pbuilder
dh clean --with python2,sphinxdoc  --buildsystem=pybuild
   dh_auto_clean -O--buildsystem=pybuild
I: pybuild base:184: python2.7 setup.py clean 
running clean
removing 
'/home/bignose/Projects/debian/pelican/build-area/pelican-3.7.1/.pybuild/pythonX.Y_2.7/build'
 (and everything under it)
'build/bdist.linux-x86_64' does not exist -- can't clean it
'build/scripts-2.7' does not exist -- can't clean it
   debian/rules override_dh_clean
make[1]: Entering directory 
'/home/bignose/Projects/debian/pelican/build-area/pelican-3.7.1'
dh_clean
rm -rf pelican.egg-info build/html
make[1]: Leaving directory 
'/home/bignose/Projects/debian/pelican/build-area/pelican-3.7.1'
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: error: unwanted binary file: 
debian/theme-substitute/notmyidea/static/images/forkme_left_white_ffffff.png
dpkg-source: error: unwanted binary file: 
debian/theme-substitute/notmyidea/static/images/forkme_right_red_aa0000.png
dpkg-source: error: detected 2 unwanted binary files (add them in 
debian/source/include-binaries to allow their inclusion).
gbp:error: 'git-pbuilder' failed: it exited with 29
=====

So the problem is that a “clean” is occurring implicitly before
building the source, even when I specify ‘--git-cleaner=/bin/true’.

> (I'll have a closer look how to reshuffle things after fixing 2 other
> bugs I'm currently on, sorry to keep you waiting).

Thank you for working on this!

-- 
 \          “When we call others dogmatic, what we really object to is |
  `\   their holding dogmas that are different from our own.” —Charles |
_o__)                                                           Issawi |
Ben Finney <b...@benfinney.id.au>

Attachment: signature.asc
Description: PGP signature

Reply via email to