On Wed, 17 Mar 2021 at 19:42, Helmut Grohne <hel...@subdivi.de> wrote:
> Hi Nilesh, > > On Wed, Mar 17, 2021 at 07:09:28PM +0530, Nilesh Patra wrote: > > --- /dev/null > > +++ b/debian/patches/cross.patch > > @@ -0,0 +1,15 @@ > > +Description: Do not hardcode pkg-config, build the needed file with > build arch compiler > > +Author: Nilesh Patra <nil...@debian.org> > > +Last-Update: 2021-03-17 > > +--- a/make_unix.sh > > ++++ b/make_unix.sh > > +@@ -25,7 +25,7 @@ > > + > > + # the actual compile > > + echo "compiling using $CC..." >&2 > > +-$CC -Wall -pedantic $CFLAGS $CPPFLAGS $LDFLAGS src/tools/txt2c.c > `pkg-config --cflags lua5.3` -o src/tools/txt2c > > ++$CC_FOR_BUILD -Wall -pedantic $CFLAGS $CPPFLAGS $LDFLAGS > src/tools/txt2c.c `$PKG_CONFIG --cflags lua5.3` -o src/tools/txt2c > > Here, you are mixing build and host tools. Yes, because that is needed to run a generated file, for example as done in #948477 The outputs of generated file for host arch looks good > Given that this apparently > works for you, it seems like lua isn't necessary at all. Yes, forgot removing that one, thanks > Can you try > dropping the lua5.3 cflags? Failing that, you should likely use > PKG_CONFIG_FOR_BUILD here. > Righty. > override_dh_auto_build: > > - sh make_unix.sh > > + CC_FOR_BUILD=$(CC_FOR_BUILD) CC=$(CC) PKG_CONFIG=$(PKG_CONFIG) sh > make_unix.sh > > If you set the variable DPKG_EXPORT_BUILDTOOLS=nonempty before including > buildtools.mk, you can drop these assignments. > Didn't know about this, thanks! Incorporated and pushed to salsa. Nilesh