Package: krb5
Version: 1.20-1
Severity: normal

Dear Maintainer,

it came to my attention that it looks like the build-time tests of MIT
krb5 are disabled in debian, via this empty d/rules override:

override_dh_auto_test:

I dug a bit in the git history, and found this commit:
https://salsa.debian.org/debian/krb5/-/commit/d35a1394078eb7dba66d763a6e5347ed3ea14204
"
Tests are not going to run on a buildd; they need to much net
"

Hinting that the tests were reaching out to the internet perhaps, and
would thus fail (probably due to firewall egress rules).

I gave this diff a try in an ubuntu ppa, and the build worked, but I
had to disable parallelization for the tests or one would fail
consistently:
diff --git a/debian/rules b/debian/rules
index bbf73a3c7b..9452277e02 100755
--- a/debian/rules
+++ b/debian/rules
@@ -143,6 +143,7 @@ override_dh_fixperms-arch:
        chmod 700 debian/krb5-kdc/etc/krb5kdc

 override_dh_auto_test:
+       dh_auto_test $(DH_BUILD_OPTS) --no-parallel

 %:
        dh $@


There are more tests that can be enabled by adding packages do build-depends:
- libcmocka-dev
- keyutils
- python3-pyrad
- slapd
- python-kdcproxy

All of the above I added and they built fine in an ubuntu kinetic ppa.
When I added libresolv-wrapper, that one failed a new test, and I
didn't investigate further.

Maybe we could start slowly, just first re-enabling the tests, and
then start adding these extra test-only build-dependencies? We won't
want to introduce flakiness to the build of this package.

Reply via email to