On Thu, Nov 9, 2023 at 3:14 AM Wookey <woo...@wookware.org> wrote: > On 2023-11-08 20:10 +0100, Martin Budaj wrote: > > as we still need to maintain Catch2 v2 API compatibility to run CI tests > > and builds on older Ubuntu images, we can't simply migrate to v3. > > Who is building 'latest' Therion on old Ubuntu? And are they getting > their sources from the Debian unstable package? Or from Upstream?
GitHub Actions has Ubuntu 20.04 and 22.04 images: https://github.com/actions/runner-images We use it to run CI tests and to build the official installer. > > For now, I'll just enable using the bundled Catch2 instead of v3 installed > > in the system. > > That's not the right approach for the Debian package, and this bug is about > the debian package. > Debian unstable has catch 3 in it. We should use it, not an old bundled > catch2 copy. > Upstream builds and Ubuntu builds can do something different if need > be but that's not a good reason for the Debian package not to > DTRT. And in general I'd expect current Ubuntu to have catch3 too so > using the system version will be appropriate there too. Sure, but to do it properly takes more time then I could currently dedicate to this, as more changes are required: - adapt the C++ sources to Catch v3 - introduce #ifs to C++ sources to switch between bundled and system headers, as v3 names them differently - modify make and cmake build systems to handle this switching I plan to do it when time allows (upstream), but for now I think that it's better to have a workaround than nothing. Best wishes Martin
