package rkhunter tags 445662 + pending thanks Hi Jörg,
Le dimanche 07 octobre 2007 à 16:13 +0200, Jörg Sommer a écrit : > Hi, > > I suggest the following improments of the cron scripts: Thanks for your work! Suggestions are always welcome. > · In the daily script, you check for “! $NICE”, but you source the > defaults config after this. I think better is something like this: > . /etc/default/rkhunter > > if [ -z "$NICE" ]; then > NICE=0 > fi Better, indeed. Added to SVN > · What do you check with “[ $(stat -c %s $OUTFILE) -ne 0 ]”? Is this the > same as “[ -s "$OUTFILE" ]”? It is! "Keep it complicated" is my new motto ;-) Changed in SVN as well (also in weekly cron job) > · (weekly script) Is it intended that the OUTFILE gets overwritten by the > second call of rkhunter? Otherwise you should use this line: > ($RKHUNTER --versioncheck; $RKHUNTER --update) 1>/dev/null 2>$OUTFILE > or use >> in the second call. Should be >> indeed. Thanks again Cheers, Julien
