On Thu, 05 Nov 2009, Mike Hommey wrote: > > No, it really doesn't work as expected. It works in lenny but doesn't work > > properly in sid. I think it might be due to a behavioural difference > > in perl's File::Find...
In fact no, it's a regression that I introduced in 3525f79792cff51757d99d45f51c96a15e6fa779. > > Attached is the suggested patch. Tell me if you have other problems. > > It seems to work properly with the patch. Would you know when this would > posible hit unstable ? ;) I don't know when we're going to upload the next version, I certainly hope in the next few weeks, it's been 2 months already since the last upload. Note however that you only need the fix to build the source package so you could in theory upload the resulting package... it can be unpacked everywhere (and rebuilt provided that they are not rebuilding the source package). > PS: I do wonder, however, how dpkg-source can be *so much* slower than > tar -jxf ; diff -ruN (15 seconds for tar and 2 s for diff vs. 3'30 for > dpkg-source in quilt mode and 3' in format 1.0) Check Dpkg::Source::Patch::add_diff_*() to understand why. AFAIK it's there that most of the time is spent. It does a manual comparison of both trees with many checks. To verify run: perl -d:Profile /usr/bin/dpkg-source -b <yourpackagedir> And look at the first lines of prof.out. Cheers, -- Raphaël Hertzog -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
