On Thu, Nov 05, 2009 at 10:13:15PM +0100, Raphael Hertzog wrote: > On Thu, 05 Nov 2009, Mike Hommey wrote: > > > No, it really doesn't work as expected. It works in lenny but doesn't work > > > properly in sid. I think it might be due to a behavioural difference > > > in perl's File::Find... > > In fact no, it's a regression that I introduced in > 3525f79792cff51757d99d45f51c96a15e6fa779. > > > > Attached is the suggested patch. Tell me if you have other problems. > > > > It seems to work properly with the patch. Would you know when this would > > posible hit unstable ? ;) > > I don't know when we're going to upload the next version, I certainly hope > in the next few weeks, it's been 2 months already since the last upload. > > Note however that you only need the fix to build the source package so you > could in theory upload the resulting package... it can be unpacked everywhere > (and rebuilt provided that they are not rebuilding the source package).
True, I forgot that buildds don't rebuild the source package. > > PS: I do wonder, however, how dpkg-source can be *so much* slower > > than > > tar -jxf ; diff -ruN (15 seconds for tar and 2 s for diff vs. 3'30 > > for > > dpkg-source in quilt mode and 3' in format 1.0) > > Check Dpkg::Source::Patch::add_diff_*() to understand why. AFAIK it's > there that most of the time is spent. It does a manual comparison of > both > trees with many checks. > > To verify run: > perl -d:Profile /usr/bin/dpkg-source -b <yourpackagedir> > And look at the first lines of prof.out. Oh my... %Time Sec. #calls sec/call F name 32.52 69.8110 44702 0.001562 Dpkg::Source::Patch::add_diff_file 29.95 64.2837 44829 0.001434 Dpkg::IPC::fork_and_exec 10.22 21.9370 44829 0.000489 Dpkg::IPC::wait_child 7.14 15.3309 97591 0.000157 File::Spec::Unix::abs2rel 4.25 9.1206 585681 0.000016 File::Spec::Unix::canonpath forking diff for each file definitely doesn't help here. But that's another story. Cheers, Mike -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
