Package: munin-node
Version: 1.2.6-10~lenny2
Severity: normal
File: /usr/share/munin/plugins/sensors_

sensors command returns a slightly different output than the
'sensors_' plugin expects:

$ sensors
f71858fg-isa-0a00
Adapter: ISA adapter
3.3V:        +3.36 V
Vcore:       +1.68 V
Vdimm:       +3.31 V
CPU:        1364 RPM
Sys:         988 RPM
Sys:         +43.5 C  (high = +70.0 C, hyst = +60.0 C)
CPU:         +21.0 C  (high = +100.0 C, hyst = +85.0 C)  sensor = Intel PECI
Sys2:        +41.6 C  (high = +100.0 C, hyst = +85.0 C)

coretemp-isa-0000
Adapter: ISA adapter
Core 0:      +35.0 C  (high = +84.0 C, crit = +100.0 C)

coretemp-isa-0001
Adapter: ISA adapter
Core 1:      +33.0 C  (high = +84.0 C, crit = +100.0 C)

coretemp-isa-0002
Adapter: ISA adapter
Core 2:      +34.0 C  (high = +84.0 C, crit = +100.0 C)

coretemp-isa-0003
Adapter: ISA adapter
Core 3:      +34.0 C  (high = +84.0 C, crit = +100.0 C)

And what the plugin detects:

$ cp /usr/share/munin/plugins/sensors_ sensors_fan
$ cp /usr/share/munin/plugins/sensors_ sensors_volt
$ ./sensors_fan config
graph_title Fans
graph_vtitle RPM
graph_args --base 1000 -l 0
graph_category sensors
$ ./sensors_volt config
graph_title Voltages
graph_vtitle Volt
graph_args --base 1000 --logarithmic
graph_category sensors

The problem is in the regex for both:

fan => {
    regex => qr/^(\S[^:]*)\s*:\s+\+?(\d+) RPM.*?(\d+) RPM/m,

volt => {
    regex => qr/^(\S[^:]*)\s*:\s+\+?(-?\d+(?:\.\d+)?)
V(?:\s+\(min\s*=\s*\+?(-?\d+(?:\.\d+)?)
V,\s*max\s*=\s*\+?(-?\d+(?:\.\d+)?) V\))/m

In both cases it's expecting there will always be more text following
the value and the "RPM/V" designation, but there is no text in my
case.

The fix is rather trivial, much like it's done for the "temp" regex,
where the part after the value is optional:

fan => {
    regex => qr/^(\S[^:]*)\s*:\s+\+?(\d+) RPM.*?((\d+) RPM)?/m,

volt => {
    regex => qr/^(\S[^:]*)\s*:\s+\+?(-?\d+(?:\.\d+)?)
V(?:\s+\(min\s*=\s*\+?(-?\d+(?:\.\d+)?)
V,\s*max\s*=\s*\+?(-?\d+(?:\.\d+)?) V\))?/m

I have also checked the file in latest munin-node package (1.4.4-1 at
this time) and it's the same there too, as well as in the
munin-monitoring.org trunk source (except that the regex there is
commented).

-- System Information:
Debian Release: 5.0.4
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.33.4 (SMP w/4 CPU cores; PREEMPT)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash

Versions of packages munin-node depends on:
ii  adduser                 3.110            add and remove users and groups
ii  gawk                    1:3.1.5.dfsg-4.1 GNU awk, a pattern scanning and pr
ii  libnet-server-perl      0.97-1           An extensible, general perl server
ii  lsb-base                3.2-20           Linux Standard Base 3.2 init scrip
ii  perl                    5.10.0-19lenny2  Larry Wall's Practical Extraction
ii  procps                  1:3.2.7-11       /proc file system utilities

Versions of packages munin-node recommends:
ii  libnet-snmp-perl              5.2.0-1    Script SNMP connections

Versions of packages munin-node suggests:
ii  ethtool                  6+20080913-1    display or change Ethernet device
pn  libdbd-pg-perl           <none>          (no description available)
pn  liblwp-useragent-determi <none>          (no description available)
ii  libnet-irc-perl          0.75-8          IRC (Internet Relay Chat) interfac
ii  libwww-perl              5.813-1         WWW client/server library for Perl
ii  lm-sensors               1:3.0.2-1+b2    utilities to read temperature/volt
ii  munin                    1.2.6-10~lenny2 network-wide graphing framework (g
pn  munin-plugins-extra      <none>          (no description available)
pn  mysql-client             <none>          (no description available)
ii  python                   2.5.2-3         An interactive high-level object-o
ii  smartmontools            5.38-2+lenny1   control and monitor storage system



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to