Myrna van Lunteren wrote: >Hi, > I'm working on DERBY-413, trying to remove the hardcoded 'localhost' from >the tests, and found this comment and subsequent line in the test >derbynet/dataSourcePermissions_net.java: >------------------ > if (TestUtil.isJCCFramework()) >{ >attrs.setProperty("driverType","4"); >/** >* As per the fix of derby-410 >* servername should now default to localhost >*/ >attrs.setProperty("serverName","localhost"); >} >------------------- > Now, if the serverName defaults to localhost, why are we passing it in? > ? > > For JCC it has to be set, so it is set if (TestUtil.isJCCFramework()). The comment might be clearer if it it said
servername should now default to localhost for derbyclient but still needs to be set for JCC.