tihom88 commented on code in PR #1215: URL: https://github.com/apache/jackrabbit-oak/pull/1215#discussion_r1396835757
########## oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LucenePropertyIndex.java: ########## @@ -1644,11 +1647,39 @@ public List<Facet> getFacets(int numberOfFacets, String columnName) throws IOExc return cachedResults.get(cacheKey); } LOG.trace("columnName = {} facet Data not present in cache...", columnName); + if (EAGER_FACET_CACHE_FILL) { Review Comment: As we are filling cache with all facets. Would it make sense to initialise it in constructor itself using future. Like @fabriziofortino did in https://github.com/apache/jackrabbit-oak/pull/1217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org