thomasmueller commented on code in PR #1215:
URL: https://github.com/apache/jackrabbit-oak/pull/1215#discussion_r1396951519
##########
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LucenePropertyIndex.java:
##########
@@ -1644,11 +1647,39 @@ public List<Facet> getFacets(int numberOfFacets, String
columnName) throws IOExc
return cachedResults.get(cacheKey);
}
LOG.trace("columnName = {} facet Data not present in cache...",
columnName);
+ if (EAGER_FACET_CACHE_FILL) {
Review Comment:
I prefer to avoid concurrency. it is filled when the first one is accessed,
so I think it "should be fine". (I know, it sounds like "famous last words")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
