Geoffrey Young wrote:


Steve Hay wrote:

Hi,

The apache/cookie.t and apache/cookie2.t tests also fail on Win32 (Apache 2.0.47, [EMAIL PROTECTED], mp2 CVS):


[Wed Sep 17 09:48:47 2003] [error] [client 127.0.0.1] Invalid URI in request GET TestApache__cookie?header HTTP/1.0

-my $location = Apache::TestRequest::module2path($module);
+my $location = '/' . Apache::TestRequest::module2path($module);

The module2path is really there because of win32, which doesn't like paths like /TestApache::cookie. But since we already provide a wrapper, this seems to be ugly:


'/' . Apache::TestRequest::module2path($module);

or at least the name is misleading (I know I gave it that name). So should we probably rename it to be module2segment or something like that, which doesn't suggest that it returns a valid path?

Alternatively fix it to append / internally, though it'll make other concatenations uglier:

my $location "http://$hostport$path";;

instead of:

my $location "http://$hostport/$path";;

or does the former look good?

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to