Geoffrey Young wrote:


my $uri = Apache::TestRequest->parse($module);
$uri->query('env');
$uri->unparse.

if Apache::TestRequest::hostport() returns true, then the unparsed value is an absolute URI, otherwise it's relative.



That sounds as too error-prone to me. What happens if the same test mixes requests to a specific hostport and to the default port as well? We have quite a few tests like this and that logic will break them.

well, of course the idea was to have a consistent API that worked and felt familiar, not one that was error prone - figuring out exactly which variant of


  Apache::TestRequest::module($module);
  my $config   = Apache::Test::config();
  my $hostport = Apache::TestRequest::hostport($config);
  my $path     = Apache::TestRequest::module2path($module);

my $location = "http://$hostport/$path";;

you need for a given situation is error prone enough for me.

I'm not following you, you suggested to add magic to automatically prepend the leading /. that's what I've called error-prone.


but you seem to have it figured out, so just do what you think is best.

Hmm, look at t/directive/perlloadmodule3.t.


Clearly we are talking about different things.

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to