This VOTE is canceled to apply Bruno's bug fix and new test case. Thank you Bruno! (Yes, attaching patches is the best way to go :)
I'll cut a new RC. Gary On Tue, Jun 12, 2012 at 2:41 PM, Bruno P. Kinoshita < brunodepau...@yahoo.com.br> wrote: > Hi Gary, > > > Looking at the FindBugs report, there is an item under > "org.apache.commons.io.FileUtils" complaining about the return value of > BigInteger.add being ignored. > > > Indeed, looks like the value is not used, causing > FileUtils.sizeOfDirectoryAsBigInteger (IO-326) to return always zero. I've > attached a patch to IO-326 in JIRA with a sample test and the fix for this > issue. Could you take a look on it and check if it makes sense or if I'm > mistaken, please? > > > Overall everythings seems great, compiled successfully on my Debian 6, Sun > JDK 1.6 :-) not binding here, but congrats on the good work :-) > > All the best, > > ps: I've attached a patch to a issue marked as Fixed in JIRA, don't know > if it is a bad practice or not allowed. If so, just let me know that I'll > file a new issue, send you the patch or do whatever is more appropriate in > this case. > > > Bruno P. Kinoshita > http://kinoshita.eti.br > http://tupilabs.com > > > >________________________________ > > From: Gary Gregory <garydgreg...@gmail.com> > >To: Commons Developers List <dev@commons.apache.org> > >Sent: Tuesday, 12 June 2012 1:07 PM > >Subject: [VOTE] Release Commons IO 2.4-RC1 > > > >Hello All: > > > >This is a VOTE to release Commons IO 2.4-RC1 > > > >Changes in this version include: > > > >New features: > >o IO-269: Tailer locks file from deletion/rename on Windows. Thanks to > >sebb. > >o IO-333: Export OSGi packages at version 1.x in addition to 2.x. Thanks > >to fmeschbe. > >o IO-320: Add XmlStreamReader support for UTF-32. Thanks to ggregory. > >o IO-331: BOMInputStream wrongly detects UTF-32LE_BOM files as > >UTF-16LE_BOM files in method getBOM(). Thanks to ggregory. > >o IO-327: Add byteCountToDisplaySize(BigInteger). Thanks to ggregory. > >o IO-326: Add new FileUtils.sizeOf[Directory] APIs to return BigInteger. > >Thanks to ggregory. > >o IO-325: Add IOUtils.toByteArray methods to work with URL and URI. > Thanks > >to raviprak. > >o IO-324: Add missing Charset sister APIs to method that take a String > >charset name. Thanks to raviprak. > > > >Fixed Bugs: > >o IO-279: Tailer erroneously considers file as new. Thanks to Sergio > >Bossa, Chris Baron. > >o IO-335: Tailer#readLines - incorrect CR handling. > >o IO-334: FileUtils.toURLs throws NPE for null parameter; document the > >behavior. > >o IO-332: Improve tailer's reading performance. Thanks to liangly. > >o IO-279: Improve Tailer performance with buffered reads (see IO-332). > >o IO-329: FileUtils.writeLines uses unbuffered IO. Thanks to tivv. > >o IO-319: FileUtils.sizeOfDirectory follows symbolic links. Thanks to > >raviprak. > > > > > >Compatibility with 2.3: > >Binary compatible: Yes. > >Source compatible: Yes. > >Semantic compatible: Yes. > > > >Compatibility with 2.2 and 1.4: > >Binary compatible: Yes. > >Source compatible: No, see the rare case in > >https://issues.apache.org/jira/browse/IO-318. > >Semantic compatible: No, see the rare case in > >https://issues.apache.org/jira/browse/IO-318. > > > >Commons IO 2.4 requires JDK 1.6 or later. > >Commons IO 2.3 requires JDK 1.6 or later. > >Commons IO 2.2 requires JDK 1.5 or later. > >Commons IO 1.4 requires JDK 1.3 or later. > > > >This VOTE is open for at least 72 hours until June 15 2012 at 13:00 EST. > > > >The files: > > > >https://repository.apache.org/content/repositories/orgapachecommons-228/ > > > >The tag: > > > >https://svn.apache.org/repos/asf/commons/proper/io/tags/2.4-RC1 > > > >The site: > > > >https://people.apache.org/builds/commons/commons-io/2.4/RC1/ > > > >Thank you, > >Gary Gregory > > > > > >-- > >E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > >JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 > >Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK > >Blog: http://garygregory.wordpress.com > >Home: http://garygregory.com/ > >Tweet! http://twitter.com/GaryGregory > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
