Le 02/04/2013 15:55, Gilles a écrit : > Hello. Hi Gilles,
> >>> >>>>> >>>>>> >>>>>> Votes, please. >>>>>> This vote will close in 72 hours: 2013-04-02T23:00:00 UTC >>>>>> >>>>>> [ ] +1 Release these artifacts >>>>>> [X] +0 OK, but... >>>>>> [ ] -0 OK, but really should fix... >>>>>> [ ] -1 I oppose this release because... >>>>> >>>>> * There are no tests for some of the distance classes >>>>> ("o.a.c.m.ml.distance"). >>>> >>>> This is bad, we should have tests for that. >>>> >>>>> * The class "PollardRho" ("o.a.c.m.primes") is untested and unused. >>>> >>>> This one is probably not a critical problem, so I would let it this way >>>> hoping further work could be done on this. >>>> >>>> Anyway, as the missing tests for distances bothers me and as I have >>>> also >>>> found new bugs in the ODE part, I cancel this vote and will cut another >>>> RC later on, once the bugs have been fixed. >>>> >>>> If in between someone could add the tests for the distance classes, it >>>> would be nice. >>> >>> Done in revision 1463534. >> >> It was fast! > > It was pretty trivial too. ;-) > [I did not mean it to be a blocker.] I know, as you have cast a +0 vote. It was me who was more worried about it, and since I also discovered a few other bugs, it was worth including them into the release too. It will just delay the release a few days, so it can be managed. Luc > >> Thanks a lot. > > You're welcome. > Gilles > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org