Wouldn't it make sense to expose typed methods like in Collections.emptyList() et al.?
On 10 May 2017 at 22:10, Javen O'Neal <one...@apache.org> wrote: > +1 > > The of method should check if all elements are null, and if so to return > the NULL singleton. This would reduce the number of objects created and > garbage collected. > > So long as ImmutablePair and ImmutableTriple classes are final (not > subclassable), then identity checking could be used in place of equality > checking when comparing against a null tuple. This would be marginally > faster. > > Any preference of being explicit (redundant) here? > ImmutablePair.NULL_PAIR and ImmutableTriple.NULL_TRIPLE > > On May 10, 2017 7:35 PM, "Gary Gregory" <garydgreg...@gmail.com> wrote: > > Hi All, > > Any thoughts for or against adding the following to ImmutablePair: > > > /** > * An immutable pair of nulls. > */ > // This is not defined with generics to avoid warnings in call sites. > @SuppressWarnings("rawtypes") > public static final ImmutablePair NULL = ImmutablePair.of(null, null); > > Same for ImmutableTriple. > > ? > > Thank you, > Gary > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > Java Persistence with Hibernate, Second Edition > <https://www.amazon.com/gp/product/1617290459/ref=as_li_ > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459& > linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8> > > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a= > 1617290459> > JUnit in Action, Second Edition > <https://www.amazon.com/gp/product/1935182021/ref=as_li_ > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021& > linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de4 > 18%22> > > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a= > 1935182021> > Spring Batch in Action > <https://www.amazon.com/gp/product/1935182951/ref=as_li_ > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951& > linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B% > 7Blink_id%7D%7D%22%3ESpring+Batch+in+Action> > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a= > 1935182951> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > -- Matt Sicker <boa...@gmail.com>