chaoyli commented on a change in pull request #887: Fix BE unit tests
URL: https://github.com/apache/incubator-doris/pull/887#discussion_r272911438
##########
File path: be/test/olap/comparison_predicate_test.cpp
##########
@@ -99,21 +99,24 @@ public: \
delete _vectorized_batch; \
} \
} \
- void SetFieldInfo(FieldInfo &field_info, std::string name, \
- FieldType type, FieldAggregationMethod aggregation, \
- uint32_t length, bool is_allow_null, bool is_key) { \
- field_info.name = name; \
- field_info.type = type; \
- field_info.aggregation = aggregation; \
- field_info.length = length; \
- field_info.is_allow_null = is_allow_null; \
- field_info.is_key = is_key; \
- field_info.precision = 1000; \
- field_info.frac = 10000; \
- field_info.unique_id = 0; \
- field_info.is_bf_column = false; \
+ void SetTabletColumn(std::string name, \
+ std::string type, std::string aggregation, \
Review comment:
const std::string&
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
