chaoyli commented on a change in pull request #887: Fix BE unit tests
URL: https://github.com/apache/incubator-doris/pull/887#discussion_r272909638
##########
File path: be/src/olap/row_cursor.h
##########
@@ -73,18 +73,27 @@ class RowCursor {
OLAPStatus init(const TabletSchema& schema,
const std::vector<uint32_t>& columns);
+ OLAPStatus init(const std::vector<TabletColumn>& schema,
+ const std::vector<uint32_t>& columns);
+
// 用传入的key的size来初始化
// 目前仅用在拆分key区间的时候
OLAPStatus init_scan_key(const TabletSchema& schema,
const std::vector<std::string>& keys);
+ OLAPStatus init_scan_key(const std::vector<TabletColumn>& schema,
Review comment:
If you call this function, you will need all columns of schema. There is no
necessary to overload with std::vector<TabletColumn>& schema parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
