[ 
https://issues.apache.org/jira/browse/FELIX-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862736#action_12862736
 ] 

Sahoo commented on FELIX-2313:
------------------------------

Let's at least remove the restriction around Bundle-Version which is not 
mandatory for r4 bundles.

I also don't know why we can't support installation of plain jars as bundles 
without breaking transformation support for wars and things like that. That can 
be achieved by giving custom ArtifactListeners a chance to look at the 
artifacts before BundleTransformer. Any way, this can be addressed separately.

> fileinstall does not recognize jars if it does not have Bundle-SymbolicName 
> and Bundle-Version
> ----------------------------------------------------------------------------------------------
>
>                 Key: FELIX-2313
>                 URL: https://issues.apache.org/jira/browse/FELIX-2313
>             Project: Felix
>          Issue Type: Bug
>          Components: File Install
>    Affects Versions: karaf-1.4.0
>            Reporter: Sahoo
>
> FileInstall does not recognize jar files that have only Bundle-SymbolicName. 
> I see the following code in BundleTransformer.java:
>            if (m.getMainAttributes().getValue(new 
> Attributes.Name("Bundle-SymbolicName")) != null
>                && m.getMainAttributes().getValue(new 
> Attributes.Name("Bundle-Version")) != null)
>  Why is this the case? Earlier fileinstall used to be able install anything 
> that's a jar file.
> Questions: Why does FileInstall care about existence of any kind of manifest 
> entries? Is not every jar file technically an OSGi bundle? So, it should be 
> sufficient to just have the following check:
> try {
>    new JarFile(artifact).close();
> } catch(Exception e){
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to