[
https://issues.apache.org/activemq/browse/AMQCPP-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_37872
]
Albert Strasheim commented on AMQCPP-36:
----------------------------------------
I think I have two new reasons for possibly moving code from headers to cpp
files: code size and build time.
The latest activemq-cpp.lib is 41,112 KB, which seems rather... large.
While we were chasing down the bug we were seeing related to AMQCPP-25, we had
to make changes to functions that were implemented in headers, causing large
parts of the library that didn't really change to be rebuilt.
> Cleanup whitespace and member function definitions in header files
> ------------------------------------------------------------------
>
> Key: AMQCPP-36
> URL: https://issues.apache.org/activemq/browse/AMQCPP-36
> Project: ActiveMQ C++ Client
> Issue Type: Improvement
> Reporter: Albert Strasheim
> Assigned To: Timothy Bish
> Priority: Minor
> Fix For: 1.1
>
> Attachments: activemq-concurrent-cleanup.diff,
> StompFrame-signmismatch.diff
>
>
> The AMQCPP code looks great in general, but many files have some stray
> whitespace. Also, there are quite a few headers that contain member function
> definitions. Some are simple, but there's also some big ones in there. I
> usually follow the rule that anything that can go into the .cpp should.
> Attached is a patch to clean up the files in activemq::concurrent. If
> Timothy/Nathan agrees that doing this is useful, I'll submit patches for the
> rest.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
