Thanks Jacek. That is a good suggestion. Here is what I have come up with in thinking about a patch:
The server java code has two directory notions: base, used with ServerInfo.resolve(), and baseServer, used with ServerInfo.resolveServer(). Base can be set with the oag.home.dir system property, and baseServer can be set with the oag.server.dir and oag.server.name system properties (where oag is short for org.apache.geronimo). The geronimo script uses GERONIMO_HOME for the bin directory, and GERONIMO_BASE for the lib and var directories. If GERONIMO_BASE is not set, it will set it to GERONIMO_HOME. Finally, on java invocation, it sets the system property oag.base.dir to GERONIMO_BASE. The java code does not read this system property! I thus have two recommendations: The quick and conservative one is to have the geronimo script set oag.home.dir to GERONIMO_BASE, instead of setting oag.base.dir. The more complex and radical recommendation is to remove GERONIMO_BASE from the geronimo script, replacing it with GERONIMO_HOME. Thanks, Ted On 1/26/07, Jacek Laskowski <[EMAIL PROTECTED]> wrote:
On 1/26/07, Ted Kirby <[EMAIL PROTECTED]> wrote: > Providing the org.apache.geronimo.home.dir system property to allow > the home directory to be passed in is good, but if this is not used > (and I'd don't feel it should be required/used in the normal case), > DirectoryUtils.getGeronimoInstallDirectory() is used to determine the > home directory. This method uses machinations that do not resolve > correctly if the home directory is a symbolic link. Since the > invoking geronimo script sets and uses GERONIMO_HOME, why does it not > pass this value into the server? I would think that BasicServerInfo > would want to set baseDirectory to GERONIMO_HOME (if the > org.apache.geronimo.home.dir system property is not set), and invoke > DirectoryUtils.getGeronimoInstallDirectory() only if GERONIMO_HOME is > not set. I think you might want to provide a patch that someone will review and commit. What do you think? if it doesn't break the tests it's a good start. Jacek -- Jacek Laskowski http://www.JacekLaskowski.pl
