--On Wednesday, February 23, 2005 3:07 AM +0100 "Branko ?ibej" <[EMAIL PROTECTED]> wrote:

A number of public functions in mod_dav.h aren't properly exported with
DAV_DECLARE. This recently became a problem for Subversion, because
mod_dav_svn now supports DAV locking, and mod_dav's locking functions were
amongst the ones that were not exported. Nobody noticed this on Unix where
DAV_DECLARE is a no-op, but Windows suffered mightily.

The attached patch (against the 2.0.x branch) fixes the problem. I had to
use DAV_DECLARE_NONSTD in a few places where the functions are used as
callbacks, because I didn't want to fiddle with the __stdcall horror in
callback parameter declarations.

Subversion 1.2, which will introduce locking functionality, will not work as
a DAV server on Windows without an httpd-2.0.x release that includes this
patch. I hope such a thing is possible in the next few months, and I'm only
sorry I was too late for the the 2.0.53 release.

I've committed it to trunk and have proposed it for backport. -- justin

P.S. I had 'fun' trying to get your name in the commit log. I hope I got it right... =)

Reply via email to