On 23.08.2012 09:22, Kaspar Brand wrote: > On 17.08.2012 10:11, Joe Orton wrote: >> On Thu, Aug 16, 2012 at 08:36:31PM +0200, Kaspar Brand wrote: >>> I wonder if we should add support for module-specific CFLAGS etc., >>> which would always appear before the EXTRA_XXX stuff in the compile >>> and link commands, i.e. in rules.mk we would have: >>> >>> ALL_CFLAGS = $(MOD_CFLAGS) $(EXTRA_CFLAGS) $(NOTEST_CFLAGS) $(CFLAGS) >>> ALL_CPPFLAGS = $(DEFS) $(INTERNAL_CPPFLAGS) $(MOD_CPPFLAGS) >>> $(EXTRA_CPPFLAGS) $(NOTEST_CPPFLAGS) $(CPPFLAGS) >>> ALL_INCLUDES = $(INCLUDES) $(MOD_INCLUDES) $(EXTRA_INCLUDES) >>> >>> ALL_LDFLAGS = $(MOD_LDFLAGS) $(EXTRA_LDFLAGS) $(NOTEST_LDFLAGS) $(LDFLAGS) >>> >>> A particular module could then set its specific MOD_CFLAGS etc. in >>> modules.mk, and these would always have priority over those possibly >>> inserted by other modules. >> >> Doing CFLAGS et al like that doesn't generalise brilliantly, because >> they are per-directory (modules/xxx) not strictly per-module, but it >> could be done anyway, and that wouldn't matter for mod_ssl. Yeah, >> probably a good idea. > > I gave it a try, and so far it seems to work as expected, see the > attached patch (against r1358166, to reduce clutter).
I have committed an improved version in r1385214 (in particular, more tweaking was required to properly handle support/ab, which can't make use of MOD_CFLAGS etc.). Reviews, further testing and feedback welcome. Kaspar
