Re: svn commit: r1913977 - /httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c

[Ruediger Pluem]

On 11/24/23 5:41 PM, Graham Leggett via dev wrote:
> On 24 Nov 2023, at 14:25, Ruediger Pluem <rpl...@apache.org> wrote:
> 
>>> +            req->dn = dn;
>>
>> Don't we need to save the vals as well?
> 
> We do - and we also need to apr_pstrdup() the dn to be consistent with the 
> rest.

Why? dn is already apr_pstrdup from r->pool:

https://github.com/apache/httpd/blob/dc76ce4c43efb8c0c36a5990aeb0468a87458087/modules/ldap/util_ldap.c#L2133

Regards

Rüdiger