On 24 Nov 2023, at 19:26, Ruediger Pluem <rpl...@apache.org> wrote: >> We do - and we also need to apr_pstrdup() the dn to be consistent with the >> rest. > > Why? dn is already apr_pstrdup from r->pool: > > https://github.com/apache/httpd/blob/dc76ce4c43efb8c0c36a5990aeb0468a87458087/modules/ldap/util_ldap.c#L2133
Looks like we were consistently wasteful due to lack of const, fixed in r1914281. Regards, Graham —
