> @@ -37,10 +37,7 @@ public String getValue() {
> }
>
> public static NetworkType fromValue(String value) {
> - for (NetworkType networkType : values()) {
> - if (networkType.getValue().equalsIgnoreCase(value))
> - return networkType;
> - }
> - return null;
> + if (value == null) return null;
If it's not a valid/expected input value, is it sensible to swallow it? If it
indicates a problem, should we rather be failing here? If we want to handle
spurious nulls more gracefully, add a log warning?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/47/files#r7892634
