Am 2018-05-07 um 23:27 schrieb Robert Scholte:
On Mon, 07 May 2018 23:14:18 +0200, Michael Osipov <micha...@apache.org>
wrote:
Am 2018-05-07 um 22:40 schrieb Robert Scholte:
That's indeed better.
Maybe a comment that when Maven requires Java9 it could be reverted
to "Java Home"?
Maybe, but still remains not technically Java, but the bundled JRE as
Oracle documents and can be confused with JAVA_HOME.
What about this one:
Apache Maven 3.5.4-SNAPSHOT
(0062eba2f82c07d4c13610fb31c8dbbb79b9184c; 2018-05-07T23:08:43+02:00)
Maven home:
D:\Entwicklung\Projekte\maven\apache-maven\target\apache-maven-3.5.4-SNAPSHOT
Java version: 1.8.0_162, vendor: Oracle Corporation, location:
C:\Program Files\Java\jdk1.8.0_162\jre
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
Seems a bit long, but consistent on one line, just saying "Java
location".
Interesting, it's complete and all Java info combined: I like it.
Having a look at the docs:
"java.home" Installation directory for Java Runtime Environment (JRE)
since it is now 1 line, we might simply say JRE, runtime or JRE folder
now...
location is fine as well, all are acceptable improvements
I really like runtime:
$ apache-maven-3.5.4-SNAPSHOT/bin/mvn -v
Apache Maven 3.5.4-SNAPSHOT (0062eba2f82c07d4c13610fb31c8dbbb79b9184c;
2018-05-07T23:30:24+02:00)
Maven home:
D:\Entwicklung\Projekte\maven\apache-maven\target\apache-maven-3.5.4-SNAPSHOT
Java version: 11-ea, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk-11
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
Makes sense now. I'll go ahead, amend the commit and merge into master.
Michae
On Mon, 07 May 2018 22:30:51 +0200, Michael Osipov
<micha...@apache.org> wrote:
Am 2018-05-07 um 21:46 schrieb Robert Scholte:
I understand the fix, but it'll be no issue anymore with Java 9+
I have my doubts about "used"? "JRE used" could also refer to a
version.
This is actually the JRE *location*, but that's quite long
"JRE Home"?
Or just do a Java check and only adjust it for Java 8 and before.
In the end it really is "java.home"...
I brought up the same argument for Java 9+, but people were still
confused and Java 8 will still be available for many years.
Oracle's docs talk about JRE installation directory, what about "JRE
installation:"? I know it is long, but unambigious.
It is not really about dropping this information, but merely
displaying which JVM this Maven instance is running.
Is the proposal acceptable with "installation"?
Michael
On Sun, 06 May 2018 00:11:36 +0200, Michael Osipov
<micha...@apache.org> wrote:
Hi folks,
who seconds MNG-5756 for 3.5.4? Several folks complain that "mvn
-v" does not correspond to the reality, therefore two PRs have
been created.
I have just changed the output to "JRE used:" instead of "Java
home:".
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
