Looks like classwork for sure. I think intent on pull request needs to be present to explain the value and maybe contributor guide should state that if it does not. The change appears to be from sonar rules. It's clearly some form of classwork when user has no GitHub history. Many classes now expect this to happen as part of the grading. I'd close this one as zero listed intent as to why and no follow up based on comments. My guess is that class is now over...
Maybe other attempts are better efforts... Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Android<https://aka.ms/AAb9ysg> ________________________________ From: Elliotte Rusty Harold <elh...@ibiblio.org> Sent: Wednesday, July 5, 2023 9:04:20 AM To: Maven Developers List <dev@maven.apache.org> Subject: Gratuitous refactorings Lately I've noticed a few random PRs from first time contributors that use some automated refactoring tool on our code for no obvious reason. Here's an example: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fmaven-assembly-plugin%2Fpull%2F131&data=05%7C01%7C%7C8fbf6f778b91461da9fa08db7d5877d7%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638241591141462000%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=hQoEcbV%2FjDBvLKGFetVIjV%2Fr%2FDjauZXYR2%2BqGNvpRYs%3D&reserved=0<https://github.com/apache/maven-assembly-plugin/pull/131> These refactorings don't seem helpful and don't IMO improve the code in any way. I'm not sure what's going on here. Perhaps Maven is getting used as an example in a training course or class somewhere. Perhaps someone is evaluated on the number of Github PRs they create or get merged. I'm inclined to close these without further comment. Thoughts? -- Elliotte Rusty Harold elh...@ibiblio.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
