----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15706/#review29274 -----------------------------------------------------------
src/zookeeper/group.cpp <https://reviews.apache.org/r/15706/#comment56428> I'm confused about the logic here. Is the expectation that if there is a retryable error when setup() is called you would get another connected() event? I was expecting the authentication step to go into a queue of its own like join,cancel etc. But that doesn't seem to be the case. Also, is it possible to write a test for this? - Vinod Kone On Nov. 22, 2013, 12:30 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15706/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2013, 12:30 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-814 > https://issues.apache.org/jira/browse/MESOS-814 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/zookeeper/group.hpp 04068e357cec95457d1f24c166d0b60f86d997d2 > src/zookeeper/group.cpp 12c781b29f4300ca8a29660adc3f1e55e03d5d04 > > Diff: https://reviews.apache.org/r/15706/diff/ > > > Testing > ------- > > make check & mesos-tests.sh > --gtest_filter=GroupTest*:ZooKeeperTest*:ZooKeeperMasterContenderDetectorTest* > with high iterations. > > This fix is for a problem not easy to expose through unit tests so no new > tests were written. > > > Thanks, > > Jiang Yan Xu > >
