> On Nov. 20, 2013, 11:23 p.m., Ben Mahler wrote:
> > Looks good, I was looking at how retry() can be initiated from several
> > locations in the code but it appears relatively harmless: we will just do
> > redundant sync() calls on occasion AFAICT.
>
> Jiang Yan Xu wrote:
> Each call to retry() is guarded by a "if (!retrying) { ... }" and
> 'retrying' is immediately set to true after it is dispatched by a delay so
> even the method on the object executed next won't be doing it again. Seems
> fine to me.
Yes but these are not "calls", rather these are "delays" and so these are
asynchronous. Meaning you need to consider what happens when retrying becomes
true after the delay but before the delayed call takes place. AFAICT this just
results in redundant sync() operations. +1 to testing this :)
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15706/#review29198
-----------------------------------------------------------
On Nov. 22, 2013, 12:30 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15706/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2013, 12:30 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-814
> https://issues.apache.org/jira/browse/MESOS-814
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/zookeeper/group.hpp 04068e357cec95457d1f24c166d0b60f86d997d2
> src/zookeeper/group.cpp 12c781b29f4300ca8a29660adc3f1e55e03d5d04
>
> Diff: https://reviews.apache.org/r/15706/diff/
>
>
> Testing
> -------
>
> make check & mesos-tests.sh
> --gtest_filter=GroupTest*:ZooKeeperTest*:ZooKeeperMasterContenderDetectorTest*
> with high iterations.
>
> This fix is for a problem not easy to expose through unit tests so no new
> tests were written.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
