Re: [mp2] make test errors w/. threadmutex, push_handlers

[Stas Bekman]

Nick Tonkin wrote:

BTW how many adopters of mp2 are we?

Just a few folks so far very reporting problems. Though it's possible that there are many others that don't have problems.

apr/threadmutex..............FAILED tests 1-3 Failed 3/3 tests, 0.00% okay

[...]
> [Sat Jan 18 21:23:17 2003] [error] [client 127.0.0.1] Can't locate
> APR/ThreadMutex.pm in @INC (@INC contains: /home/tmp/build/modperl-2.0/t
> /home/tmp/build/modperl-2.0/blib/lib/Apache2
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
it is in this directory, right?

Nope:

nick@fatboy /tmp/build/modperl-2.0>ll /home/tmp/build/modperl-2.0/blib/lib/Apache2
total 24
drwxr-xr-x  2 nick  perl  -   512 Jan 18 21:22 APR/
-r--r--r--  1 nick  perl  -   325 Sep 12  2001 APR.pm
drwxr-xr-x  2 nick  perl  -  1024 Jan 18 21:22 Apache/
drwxr-xr-x  2 nick  perl  -   512 Jan 18 21:22 ModPerl/
drwxr-xr-x  6 nick  perl  -   512 Jan 18 21:22 auto/
-r--r--r--  1 nick  perl  -    94 Jan 10 20:17 mod_perl.pm
-r--r--r--  1 nick  perl  - 11231 Jan 18 21:21 typemap

nick@fatboy /tmp/build/modperl-2.0>ll
/home/tmp/build/modperl-2.0/blib/lib/Apache2/APR
total 34
-r--r--r--  1 nick  perl  - 537 Jan 18 21:21 Base64.pm
-r--r--r--  1 nick  perl  - 538 Jan 18 21:21 Brigade.pm
-r--r--r--  1 nick  perl  - 537 Jan 18 21:21 Bucket.pm
-r--r--r--  1 nick  perl  - 160 Apr 11  2001 Const.pm
-r--r--r--  1 nick  perl  - 535 Jan 18 21:21 Date.pm
-r--r--r--  1 nick  perl  - 537 Jan 18 21:21 NetLib.pm
-r--r--r--  1 nick  perl  - 533 Jan 18 21:21 OS.pm
-r--r--r--  1 nick  perl  - 191 Dec 17  2001 PerlIO.pm
-r--r--r--  1 nick  perl  - 535 Jan 18 21:21 Pool.pm
-r--r--r--  1 nick  perl  - 539 Jan 18 21:21 SockAddr.pm
-r--r--r--  1 nick  perl  - 537 Jan 18 21:21 Socket.pm
-r--r--r--  1 nick  perl  - 537 Jan 18 21:21 String.pm
-r--r--r--  1 nick  perl  - 536 Jan 18 21:21 Table.pm
-r--r--r--  1 nick  perl  - 534 Jan 18 21:21 URI.pm
-r--r--r--  1 nick  perl  - 535 Jan 18 21:21 UUID.pm
-r--r--r--  1 nick  perl  - 535 Jan 18 21:21 Util.pm
-r--r--r--  1 nick  perl  - 248 May 23  2002 XSLoader.pm


nick@fatboy /tmp/build/modperl-2.0>sudo find / -name 'ThreadMutex.pm' -print
/home/tmp/build/modperl-2.0/WrapXS/APR/ThreadMutex/ThreadMutex.pm

So you don't have APR/ThreadMutex.pm in blib and the error was correct.

And what's your WrapXS/APR/ThreadMutex/Makefile's pm_to_blib target says?
Mine says:
pm_to_blib: $(TO_INST_PM)
@$(PERLRUNINST) "-MExtUtils::Install" \
-e "pm_to_blib({qw{ThreadMutex.pm ../../../blib/lib/Apache2/APR/ThreadMute
x.pm}},'$(INST_LIB)/auto','$(PM_FILTER)')"
@$(TOUCH) $@

Also I get:

% grep HAS_THREADS lib/Apache/BuildConfig.pm

'HAS_THREADS' => '1',

you probably have 0, right? If so:

Also, I'm not sure why an undef is returned here, I'd think it should be:

Index: lib/ModPerl/MM.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/lib/ModPerl/MM.pm,v
retrieving revision 1.21
diff -u -r1.21 MM.pm
--- lib/ModPerl/MM.pm 23 Jun 2002 21:46:54 -0000 1.21
+++ lib/ModPerl/MM.pm 20 Jan 2003 05:06:53 -0000
@@ -178,7 +178,7 @@
my $apr_config = build_config()->get_apr_config();

if ($path =~ m/(Thread|Global)Mutex/) {
- return unless $apr_config->{HAS_THREADS};
+ return '' unless $apr_config->{HAS_THREADS};
}

return '' if $path =~ m/\.(pl|cvsignore)$/;

error/push_handlers..........# Failed test 1 in error/push_handlers.t at
line 14
error/push_handlers..........FAILED test 1 Failed 1/1 tests, 0.00% okay

[...]
> [Sat Jan 18 21:23:27 2003] [error] [client 127.0.0.1] File does not exist: /home/tmp/build/modperl-2.0/t/htdocs/TestError::push_handlers

This is a new test I've added recently, unrelated to the original problem.
For some reason it wasn't auto-configured. Do you have a Location entry for TestError::push_handlers in t/conf/httpd.conf?i

Yep:

<Location /TestError::push_handlers>
SetHandler modperl PerlResponseHandler TestError::push_handlers
</Location>

Does it appear when you run t/TEST -conf?

Nope:

nick@fatboy /tmp/build/modperl-2.0>t/TEST -conf
*** cleaning out current configuration
*** reconfiguration done

nick@fatboy /tmp/build/modperl-2.0>ll /home/tmp/build/modperl-2.0/t/htdocs/TestError::push_handlers
ls: /home/tmp/build/modperl-2.0/t/htdocs/TestError::push_handlers: No such file or directory

Of course the file doesn't exist, it's a location target. What happens if you run this test:

t/TEST -v error/push_handlers

__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]