On Tue, 21 Jan 2003, Stas Bekman wrote:

> Nick Tonkin wrote:
> > On Mon, 20 Jan 2003, Stas Bekman wrote:
> > 
> > 
> >>Nick Tonkin wrote:
> >>
> >>>>>apr/threadmutex..............FAILED tests 1-3                                
> >>>>>       Failed 3/3 tests, 0.00% okay
> [...]
> 
> Thanks Nick and Andrew for debugging on this one. 

heh. Thank you all for fixing it!

> I was able to reproduce the 
> problem by turning APR_HAS_THREADS off in apr.h and rebuilding mod_perl. It's 
> OK that APR::ThreadMutex is not copied. The test wasn't doing the right 
> checking, the following should fix it (committed to cvs):
> 
> Index: t/response/TestAPR/threadmutex.pm
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/t/response/TestAPR/threadmutex.pm,v
> retrieving revision 1.2
> diff -u -r1.2 threadmutex.pm
> --- t/response/TestAPR/threadmutex.pm   23 Jun 2002 22:14:26 -0000      1.2
> +++ t/response/TestAPR/threadmutex.pm   21 Jan 2003 06:51:47 -0000
> @@ -12,7 +12,7 @@
>   sub handler {
>       my $r = shift;
> 
> -    plan $r, tests => 3, 'APR::ThreadMutex';
> +    plan $r, tests => 3, have 'APR::ThreadMutex';
> 
>       require APR::ThreadMutex;

Looks good:

apr/table....................ok                                              
apr/threadmutex..............skipped
        all skipped: cannot find module 'APR::ThreadMutex'
apr/util.....................ok                                              

But still:

directive/setupenv...........ok                                              
error/push_handlers..........# Failed test 1 in error/push_handlers.t at
line 14
error/push_handlers..........FAILED test 1                                   
        Failed 1/1 tests, 0.00% okay
filter/in_bbs_body...........ok                                              

and this in the test error log:

[Tue Jan 21 08:03:18 2003] [error] [client 127.0.0.1] File does not exist: 
/home/tmp/build/modperl-2.0/t/htdocs/TestError::push_handlers
FILTER READ: 1024 bytes
[Tue Jan 21 08:03:26 2003] [error] [client 127.0.0.1] File does not exist: 
/home/tmp/build/modperl-2.0/t/htdocs/nope
[Tue Jan 21 08:03:32 2003] [error] [client 127.0.0.1] need AuthName: 
/TestModperl::setauth
[Tue Jan 21 08:03:35 2003] [info] removed PID file 
/home/tmp/build/modperl-2.0/t/logs/httpd.pid (pid=24418)
[Tue Jan 21 08:03:35 2003] [notice] caught SIGTERM, shutting down
END in modperl_extra.pl, pid=24418

- nick

~~~~~~~~~~~~~~~~~~~~   
Nick Tonkin   {|8^)>



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to