[EMAIL PROTECTED] wrote:
stas 2003/03/02 19:50:55
Modified: . STATUS Log: log the issue with ${^TAINT} returning -1 with blead-perl-ithreads
Can somebody please test whether you get
t/TEST modperl/taint
fail on winXX with ithreads blead perl? (it won't fail with 5.8.0, since this feature was introduced after 5.8.0).
Please disregard this request. This was a bug in blead-perl.
Revision Changes Path
1.37 +15 -1 modperl-2.0/STATUS
Index: STATUS
===================================================================
RCS file: /home/cvs/modperl-2.0/STATUS,v
retrieving revision 1.36
retrieving revision 1.37
diff -u -r1.36 -r1.37
--- STATUS 3 Mar 2003 03:36:17 -0000 1.36
+++ STATUS 3 Mar 2003 03:50:55 -0000 1.37
@@ -50,6 +50,20 @@
Needs Patch or Further Investigation:
-------------------------------------
+* in blead-perl (where ${^TAINT} returns -1 for -t and 1 for -T, 0
+ otherwise). in modperl/taint test under worker mpm ${^TAINT} returns
+ -1, when it should be 1. and the test fails
+
+ in mg.c :
+ else if (strEQ(mg->mg_ptr, "\024AINT"))
+ sv_setiv(sv, PL_tainting
+ ? (PL_taint_warn || PL_unsafe ? -1 : 1)
+ : 0);
+
+ need to check whether something different happens to PL_taint_warn
+ || PL_unsafe under worker mpm (it does the right thing with
+ prefork).
+
* 'SetHandler modperl' doesn't reset $|, so if anything turns it on
anywhere, it's going to stay that way. Meaning excessive flushing
probably causing a performance hit. I've tried to add the code to
--
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
