I need my cofee before sending small patches ;-)

Here is a revised small-patch:

Index: Makefile.PL
===================================================================
RCS file: /home/cvs/modperl-2.0/Makefile.PL,v
retrieving revision 1.125
diff -u -I$Id: -r1.125 Makefile.PL
--- Makefile.PL 21 Sep 2003 03:05:18 -0000      1.125
+++ Makefile.PL 22 Oct 2003 16:50:54 -0000
@@ -62,6 +62,7 @@
 ModPerl::BuildMM::WriteMakefile(
     NAME      => 'mod_perl',
     VERSION   => $VERSION,
+    NO_META   => 1,
     EXE_FILES => [EMAIL PROTECTED],
     DEFINE    => get_DEFINE(),
     macro     => {
Index: META.yml
===================================================================
RCS file: META.yml
diff -N META.yml
--- /dev/null   1 Jan 1970 00:00:00 -0000
+++ META.yml    22 Oct 2003 16:50:54 -0000
@@ -0,0 +1,7 @@
+name:         mod_perl
+version_from: lib/mod_perl.pm
+installdirs:  site
+private:
+    directory:
+        - Apache-Test
+distribution_type: module


On Tue, 2003-10-21 at 15:31, Stas Bekman wrote:
> Philippe M. Chiasson wrote:
> > From what I've read on the p5p archives, shouldn't this work like we
> > want it to?
> > 
> > Index: META.yml
> > ===================================================================
> > RCS file: META.yml
> > diff -N META.yml
> > --- /dev/null       1 Jan 1970 00:00:00 -0000
> > +++ META.yml        21 Oct 2003 23:14:08 -0000
> > @@ -0,0 +1,11 @@
> > +# http://module-build.sourceforge.net/META-spec.html
> > +#XXXXXXX This is a prototype!!!  It will change in the future!!! XXXXX#
> > +name:         mod_perl
> > +version:      1.99_11-dev
> 
> eh, that's not fun. hardcoded version number? what's version_from in then for?
> 
> > +version_from: lib/mod_perl.pm
> > +installdirs:  site
> > +requires:
> > +private:
> > +    directory:
> > +        - Apache::Test
> 
> that should be Apache-Test
> 
> > +distribution_type: module
> > Index: Makefile.PL
> > ===================================================================
> > RCS file: /home/cvs/modperl-2.0/Makefile.PL,v
> > retrieving revision 1.125
> > diff -u -I$Id: -r1.125 Makefile.PL
> > --- Makefile.PL     21 Sep 2003 03:05:18 -0000      1.125
> > +++ Makefile.PL     21 Oct 2003 23:14:08 -0000
> > @@ -62,6 +62,7 @@
> >  ModPerl::BuildMM::WriteMakefile(
> >      NAME      => 'mod_perl',
> >      VERSION   => $VERSION,
> > +    NO_META   => 1,
> >      EXE_FILES => [EMAIL PROTECTED],
> >      DEFINE    => get_DEFINE(),
> >      macro     => {
> 
> the rest looks good.
> 
> 
> __________________________________________________________________
> Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
> http://stason.org/     mod_perl Guide ---> http://perl.apache.org
> mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
> http://modperlbook.org http://apache.org   http://ticketmaster.com
-- 
--------------------------------------------------------------------------------
Philippe M. Chiasson /gozer\@(cpan|ectoplasm)\.org/ 88C3A5A5 (122FF51B/C634E37B)
http://gozer.ectoplasm.org/    F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3 A5A5
Q: It is impossible to make anything foolproof because fools are so ingenious.
perl -e'$$=\${gozer};{$_=unpack(P7,pack(L,$$));/^JAm_pH\n$/&&print||$$++&&redo}'

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to