Thanks,
fixed the documentation in r1723756 and r1723757.

> On 08 Jan 2016, at 17:43, Carsten Ziegeler <cziege...@apache.org> wrote:
> 
> Konrad Windszus wrote
>> Thanks for clarifying. I will update the doc accordingly. Is it possible to 
>> combine run mode with start level handling by putting e.g. a bundle within
>> <sling.fileinstall.dir>/install.dev1.a1/3/mybundle.jar?
> 
> Yes.
> 
>> If I understand the code correctly the run mode can only be set directly 
>> within a folder name directly below one of <sling.fileinstall.dir>s, right, 
>> while the start level handling is set on the direct parent folder of the 
>> artifact itself.
> 
> Yes, correct
> 
> Regards
> Carsten
> 
>> Thanks for a quick confirmation here as well.
>> Konrad
>> 
>> 
>>> On 08 Jan 2016, at 17:17, Carsten Ziegeler <cziege...@apache.org> wrote:
>>> 
>>> Konrad Windszus wrote
>>>> Hi,
>>>> according to 
>>>> https://sling.apache.org/documentation/bundles/file-installer-provider.html#runmode-support
>>>>  
>>>> <https://sling.apache.org/documentation/bundles/file-installer-provider.html#runmode-support>
>>>>  the file installer supports run modes if within the watched folder there 
>>>> is a folder with a name specifying a run mode.
>>>> By looking at the code 
>>>> https://github.com/apache/sling/blob/trunk/installer/providers/file/src/main/java/org/apache/sling/installer/provider/file/impl/Installer.java#L146
>>>>  
>>>> <https://github.com/apache/sling/blob/trunk/installer/providers/file/src/main/java/org/apache/sling/installer/provider/file/impl/Installer.java#L146>
>>>>  to me it seems that this run mode handling is only active if the folder 
>>>> has the prefix “install.” This is not mentioned at all in the 
>>>> documentation.
>>>> Is this rather an oversight in the code or is the documentation just not 
>>>> clear enough in that regard?
>>>> I can update the documentation once it is clear to me, whether the code is 
>>>> behaving correctly in that regard.
>>> 
>>> I think the docs are wrong :( According to SLING-4478 the folder name
>>> must start with that prefix.
>>> 
>>> Regards
>>> Carsten
>>> -- 
>>> Carsten Ziegeler
>>> Adobe Research Switzerland
>>> cziege...@apache.org
>> 
>> 
> 
> 
> 
> -- 
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org

Reply via email to