http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4707





------- Additional Comments From [EMAIL PROTECTED]  2005-11-28 10:38 -------
Heh, heh, yes, when I'm shaving off fractions of a microsecond I sometimes get
stuck in a mode of thinking in terms of pointers and registers and forget to
write like a human :-)

I noticed another potential array out of bounds reference in the code after this
section where it looks for the end of message "\n.\n" marker that could happen
with malformed input, and I realized that the "6" should be bigger to leave room
for a possible "\nDATA\r\n" and for the required closing "\n.\n".

So I've updated using the faster code, following Loren's suggestion to use
subscript syntax, and with a minor correction (q instead of q+1) that fixes a
very obscure edge case.

I also commented out a static const that is not used anywhere that for some
reason generates a compiler warning with gcc on my MacOS X system but not with
Fedora Core 4 gcc.

Committed to trunk revision 349405.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to