This issue has revealed another problem: we still have deprecated initialization methods taking an ExtendedProperties object. But I had totally overlooked the fact that since we now use shading, the method signatures will change anyway. Even if we avoid shading this one specific class, we can't decently keep an undeclared dependency, even for backward compatibility.

To upgrade, frameworks using this setExtendedProperties method just have to use it with our cloned class, o.a.v.util.ExtProperties.

Plus, getting rid of ExtendedProperties can allow us to upgrade our dependency to commons-collections v4.1.

  Claude

On 08/12/2016 19:10, Claude Brisson wrote:
Our first 2.0 JIRA entry! Champagne!


On 08/12/2016 17:38, Mary Helm (JIRA) wrote:
Mary Helm created VELOCITY-878:
----------------------------------

              Summary: commons collections is required at run time
                  Key: VELOCITY-878
URL: https://issues.apache.org/jira/browse/VELOCITY-878
              Project: Velocity
           Issue Type: Bug
           Components: Engine
     Affects Versions: 2.0
             Reporter: Mary Helm


The Velocity upgrading page states that •commons-lang, commons-collections and commons-logging aren't needed any more at runtime. However, commons collections is still required. Here is the error received when using the latese version (4.1) of commons-collections jar: Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/commons/collections/ExtendedProperties at org.apache.velocity.runtime.RuntimeInstance.<init>(RuntimeInstance.java:175) at org.apache.velocity.app.VelocityEngine.<init>(VelocityEngine.java:60)
...
...
Caused by: java.lang.ClassNotFoundException: org.apache.commons.collections.ExtendedProperties
    at java.net.URLClassLoader.findClass(Unknown Source)
    at java.lang.ClassLoader.loadClass(Unknown Source)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



Reply via email to