> If other smsc's use standard dcs as of ETSI 03.38, they could just
> use "dcs = fields_to_dcs(msg, 0); " and "fields_to_dcs(dcs, &msg);"
> when receiving a message.
>
> I've patched all other smsc_*.c code (I hope I didn't introduce bugs )
> so they already parse coding = DC_8BIT and coding = DC_UCS2 just
> like flag_8bit before.
>
Why do you need to call the fields_to_dcs() function for each smsc_
in the bearer box ? Maybe its more efficient to call it once on
message creation in the sms box and carry the DCS across in the Msg
struct from the sms box to the bearer box ? This also has the
architecturally desirable effect of removing *service* elements
(ie. flash, compress, mwi etc) from the Msg struct and replacing
them with a single relevant protocol value. The services can then
be mapped to and from the dcs Msg value at the point of interest
(ie. the sms box).
Given that Kannel is a distributed architecture, minimising the Msg
struct should be an efficiency goal.
A complaint about the ChangeLog - several recent entries have omitted
the module names when describing changes. This makes it next to
impossible to review changes.
