Paul Keogh wrote:
>
> This module contains the pass_extension_headers() function, the purpose
> of which is to valid the structure of extension headers in the Push message.
> However, the function contains the line of code -
>
> if ((octstr_case_search(*body_part, octstr_imm("Content"), 0)) < 0)
> goto end;
>
> which fails completely if the message body actually contains the word 'Content'.
Yep. We must parse this properly.
>
> Why is this check necessary at all - at this point the message could contain a
> mixture of WAP header extensions, User header extensions and non-normative
> Internet header extensions - so what's the point in looking for a specific keyword ?
These are multipart part headers.
>
> Also, on a related note, the pass_data_headers() function looks for headers of
> type Content-Transfer-Encoding, Content-ID and Content-Description. These are not
> listed among the generic headers in 6.2.1 (WAP-145-PushMessage), so why are they
> expected ?
I wanted parser to parse a general multipart message (which is actually
a
requirement).
Aarno
