As I say this is semantics, its not entirely necessary. Usually in library functions they are compatible with each other, eg:
SMPP_PDU *pdu = smpp_pdu_unpack(smpp_pdu_pack(data)); Would work, but in Kannel's case this doesn't work as the one function uses length and the other does not. So the third party user has to now worry about PDU internals to get the functions to work together. On 26 September 2016 at 19:31, Stipe Tolj <st...@kannel.org> wrote: > Am 24.09.2016 13:58, schrieb Rene Kluwen: > >> Sure, but why not change KSMPPD to use smpp_pdu_pack() function without >> the length? >> > > correct, IF this is something ksmppd needs/wants, then it needs to handle > it on it's side. > > What is the purpose of NOT having the length being added? > > Stipe > > -- > Best Regards, > Stipe Tolj > > ------------------------------------------------------------------- > Düsseldorf, NRW, Germany > > Kannel Foundation tolj.org system architecture > http://www.kannel.org/ http://www.tolj.org/ > > stolj at kannel.org st at tolj.org > ------------------------------------------------------------------- > > -- Donald Jackson
