Roland Scheidegger wrote:
> Keith Whitwell wrote:
> >> The rendering errors are a harder problem though, I can see now why
> >> the material between begin/end fallback was needed in the first place.
> >> There doesn't seem to be an easy way currently to submit material
> >> changes between vertices, so it looks like the fallback needs to stay
> >> (even though it doesn't really seem to work correctly neither for some
> >> reason).
> >
> >
> > Certainly the bug with the current code should be resolved - I can't
> > think it's too difficult - as the r100 will need it.
> >
> > The r200 *can* do material changes inside begin/end - basically by using
> > the R200_LM1_SOURCE_VERTEX_COLOR_0..7 arrays to track the material
> > attributes and then wiring each of these up just like in the
> > glColorMaterial case.
> I don't doubt the *chip* can do - I just doubt *I* can do it ;-).
> Wouldn't it be necessary (and sufficient) just to update the two (front
> and back) materials, or are you suggesting that it's necessary to send
> the materials along with the other vertex parameters such as the
> normals, colors etc.
> But updating the current materials would mean that the vertices up to
> now have to be flushed (?), since as far as I understand the driver it
> doesn't allow vertex data to be mixed arbitrarily with other state
> change commands. I'll admit though I don't understand it really...
> I tried to implement something like that as a quick hack - it fixed the
> errors, but looking a bit closer not for the reasons I thought it might
> help. I just called _tnl_FlushVertices( ctx, ~0 ) at the end of
> _tnl_Materialfv (t_vtx_api.c), but the strange thing is as far as I can
> see this won't do anything if it's called inside a primitive.
> Nevertheless, it fixed the rendering errors in specivewperf proe-02. Wierd.
Your GREAT patch let me run viewperf-6.1.2 DRV-07 for the FIRST time.
_All_ trials before hang the chip (even killing X remotely) lock the system
solid. But some broken (huge) triangles with right (?) colors.
Picture available.
Impressive speedup for all the other tests.
Wireframe could be faster (and was).
Advanced Visualizer (AWadvs-04) Viewset
-------------------------------------------------------------------------------
Test Weight Frames DList Visual Double Frame Buffer Accumulation
# % Per Sec Build ID Buffer R G B A Z Stencil R G B A
-------------------------------------------------------------------------------
1 21.00 86.00 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
2 21.00 97.70 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
3 14.00 89.60 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
4 14.00 86.10 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
5 6.00 97.70 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
6 5.00 90.20 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
7 5.00 96.10 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
8 4.00 102.00 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
9 4.00 107.00 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
10 3.00 102.00 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
11 3.00 107.00 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
--------------------------------------------------------------------------------
Weighted Geometric Mean = 92.746
Design Review (DRV-07) Viewset
-------------------------------------------------------------------------------
Test Weight Frames DList Visual Double Frame Buffer Accumulation
# % Per Sec Build ID Buffer R G B A Z Stencil R G B A
-------------------------------------------------------------------------------
1 75.00 6.60 0.000 0X29 True 8 8 8 8 24 0 16 16 16 16
2 13.00 5.30 0.000 0X29 True 8 8 8 8 24 0 16 16 16 16
3 4.00 6.60 0.000 0X29 True 8 8 8 8 24 0 16 16 16 16
4 4.00 5.70 0.000 0X29 True 8 8 8 8 24 0 16 16 16 16
5 4.00 4.10 0.000 0X29 True 8 8 8 8 24 0 16 16 16 16
--------------------------------------------------------------------------------
Weighted Geometric Mean = 6.256
Data Explorer (DX-06) Viewset
-------------------------------------------------------------------------------
Test Weight Frames DList Visual Double Frame Buffer Accumulation
# % Per Sec Build ID Buffer R G B A Z Stencil R G B A
-------------------------------------------------------------------------------
1 40.00 29.70 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
2 20.00 29.90 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
3 10.00 28.20 0.060 0X27 True 8 8 8 8 24 0 0 0 0 0
4 8.00 31.80 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
5 5.00 28.20 0.050 0X27 True 8 8 8 8 24 0 0 0 0 0
6 5.00 32.00 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
7 5.00 29.60 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
8 2.50 6.70 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
9 2.50 29.60 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
10 2.00 28.30 0.050 0X27 True 8 8 8 8 24 0 0 0 0 0
--------------------------------------------------------------------------------
Weighted Geometric Mean = 28.661
Lightscape (Light-04) Viewset
-------------------------------------------------------------------------------
Test Weight Frames DList Visual Double Frame Buffer Accumulation
# % Per Sec Build ID Buffer R G B A Z Stencil R G B A
-------------------------------------------------------------------------------
1 25.00 2.80 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
2 25.00 8.20 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
3 25.00 1.70 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
4 25.00 4.50 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
--------------------------------------------------------------------------------
Weighted Geometric Mean = 3.633
MedMCAD (MedMCAD-01) Viewset
-------------------------------------------------------------------------------
Test Weight Frames DList Visual Double Frame Buffer Accumulation
# % Per Sec Build ID Buffer R G B A Z Stencil R G B A
-------------------------------------------------------------------------------
1 10.00 24.10 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
2 10.00 24.00 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
3 10.00 19.80 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
4 10.00 19.70 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
5 7.50 8.40 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
6 7.50 8.40 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
7 7.50 7.00 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
8 7.50 7.00 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
9 7.50 6.60 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
10 7.50 6.60 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
11 7.50 8.40 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
12 7.50 8.40 0.000 0X27 True 8 8 8 8 24 0 0 0 0 0
--------------------------------------------------------------------------------
Weighted Geometric Mean = 11.559
Pro/Designer (ProCDRS-03) Viewset
-------------------------------------------------------------------------------
Test Weight Frames DList Visual Double Frame Buffer Accumulation
# % Per Sec Build ID Buffer R G B A Z Stencil R G B A
-------------------------------------------------------------------------------
1 25.00 21.80 0.040 0X27 True 8 8 8 8 24 0 0 0 0 0
2 25.00 21.90 0.040 0X27 True 8 8 8 8 24 0 0 0 0 0
3 10.00 6.80 0.070 0X27 True 8 8 8 8 24 0 0 0 0 0
4 10.00 8.30 0.060 0X27 True 8 8 8 8 24 0 0 0 0 0
5 5.00 5.70 0.090 0X27 True 8 8 8 8 24 0 0 0 0 0
6 5.00 7.00 0.090 0X27 True 8 8 8 8 24 0 0 0 0 0
7 3.00 3.70 0.070 0X27 True 8 8 8 8 24 0 0 0 0 0
8 3.00 4.50 0.060 0X27 True 8 8 8 8 24 0 0 0 0 0
9 7.00 12.30 0.110 0X27 True 8 8 8 8 24 0 0 0 0 0
10 7.00 12.50 0.100 0X27 True 8 8 8 8 24 0 0 0 0 0
--------------------------------------------------------------------------------
Weighted Geometric Mean = 13.024
Cheers,
Dieter
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
--
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel
