[
https://jira.duraspace.org/browse/DS-768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=22779#comment-22779
]
Tim Donohue edited comment on DS-768 at 10/11/11 5:08 PM:
----------------------------------------------------------
Hi All,
I did a bit of testing this morning. I actually cannot get the Trunk code at
https://scm.dspace.org/svn/repo/modules/dspace-cocoon-servlet-service-impl/trunk/
working.
Here's the behavior I'm seeing using Tomcat 7:
1) From Trunk code I get a 200 OK at all times if I do the following:
* Build (mvn clean install)
https://scm.dspace.org/svn/repo/modules/dspace-cocoon-servlet-service-impl/trunk/
-> builds a 1.0.3-SNAPSHOT version
* Change dependency in
[dspace-src]/dspace-xmlui/dspace-xmlui-wing/pom.xml to point at version
1.0.3-SNAPSHOT
* Rebuild DSpace (mvn clean package) - You should see the
1.0.3-SNAPSHOT version get pulled into XMLUI's WEB-INF/lib/
* Clear Tomcat cache & startup & test
* No matter what invalid path I enter, I seem to always get a 200 OK.
2) I also get a 200 OK at all times if I use the 1.0.2 version released to
Maven Central.
3) However, if I manually drop in the 1.0.2 JAR that Kim attached above, then I
get the "404 Not Found" response as expected.
All of the above makes me suspect that Kim's changes are not actually
implemented at:
https://scm.dspace.org/svn/repo/modules/dspace-cocoon-servlet-service-impl/trunk/
I suspect something must be missing in that code (but I'm not familiar enough
with it to know what is missing). However, I do notice that the code changes
in the '[DS-768]_dspace-cocoon-servlet-service-impl-1_0_2.patch' attached above
do not seem to be implemented in that trunk code (I had mentioned this to Kim
yesterday, but he thought that patch may be out-of-date).
In any case, I'm not sure a 1.0.3 release will change anything quite yet. I
believe the trunk code itself is not working right (though this could use more
eyes on it to make sure the behavior I'm seeing is consistent with others)
was (Author: tdonohue):
Hi All,
I did a bit of testing this morning. I actually cannot get the Trunk code at
https://scm.dspace.org/svn/repo/modules/dspace-cocoon-servlet-service-impl/trunk/
working.
Here's the behavior I'm seeing using Tomcat 7:
1) From Trunk code I get a 200 OK at all times if I do the following:
* Build
https://scm.dspace.org/svn/repo/modules/dspace-cocoon-servlet-service-impl/trunk/
-> builds a 1.0.3-SNAPSHOT version
* Change dependency in
[dspace-src]/dspace-xmlui/dspace-xmlui-wing/pom.xml to point at version
1.0.3-SNAPSHOT
* Rebuild DSpace (mvn clean package)
* Clear Tomcat cache & startup & test
* No matter what invalid path I enter, I seem to always get a 200 OK.
2) I also get a 200 OK at all times if I use the 1.0.2 version released to
Maven Central.
3) However, if I manually drop in the 1.0.2 JAR that Kim attached above, then I
get the "404 Not Found" response as expected.
All of the above makes me suspect that Kim's changes are not actually
implemented at:
https://scm.dspace.org/svn/repo/modules/dspace-cocoon-servlet-service-impl/trunk/
I suspect something must be missing in that code (but I'm not familiar enough
with it to know what is missing). However, I do notice that the code changes
in the '[DS-768]_dspace-cocoon-servlet-service-impl-1_0_2.patch' attached above
do not seem to be implemented in that trunk code (I had mentioned this to Kim
yesterday, but he thought that patch may be out-of-date).
In any case, I'm not sure a 1.0.3 release will change anything quite yet. I
believe the trunk code itself is not working right (though this could use more
eyes on it to make sure the behavior I'm seeing is consistent with others)
> All XMLUI Error Pages respond with 200 OK, instead of 404 Not Found
> -------------------------------------------------------------------
>
> Key: DS-768
> URL: https://jira.duraspace.org/browse/DS-768
> Project: DSpace
> Issue Type: Bug
> Components: XMLUI
> Affects Versions: 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.8.0
> Reporter: Tim Donohue
> Assignee: Kim Shepherd
> Priority: Major
> Fix For: 1.8.0
>
> Attachments:
> add_ResourceNotFoundException_to_xmlui_transformers.patch,
> [DS-768]_add_ProcessingException_to_transformers,
> [DS-768]_dspace-cocoon-servlet-service-impl-1_0_2.patch,
> dspace-cocoon-servlet-service-impl-1.0.2.jar, Screen shot 2011-08-17 at
> 2.20.40 PM.png, Screenshot-Resource not found-Mozilla Firefox.png
>
>
> In DSpace 1.7.0 RC1, the XMLUI "Page Not Found" page responds with a 200 OK,
> rather than the necessary 404 Not Found error.
> For example:
> http://demo.dspace.org/xmlui/NOTAVALIDPATH
> I believe this used to function properly in 1.6.x, but it seems to be broken
> now.
> Obviously, we want this to return a 404 Not Found, in order to ensure that
> search engines do not index "Page Not Found" responses.
> Furthermore, it has been discovered that all other XMLUI Error pages (Cocoon
> Errors or Invalid Continuation errors) also respond with 200 OK. In
> addition, it seems this affects all 1.6.x versions of DSpace, as the same
> responses can be found on http://dspace.mit.edu (currently running 1.6.0 with
> patches), and http://researchspace.auckland.ac.nz (currently running 1.6.2
> with patches).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2d-oct
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
