[
https://jira.duraspace.org/browse/DS-768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=22787#comment-22787
]
Tim Donohue commented on DS-768:
--------------------------------
Your working copy may have that patch, but I've verified that SCM does not.
For instance, notice that the HttpServletResponseBufferWrapper in our SCM does
*not* define the new 'ForwardingOrLimitingServletOutputStream' inner class
(instead it uses the older 'LimitingServletOutputStream' inner class).
http://scm.dspace.org/svn/repo/modules/dspace-cocoon-servlet-service-impl/trunk/src/main/java/org/apache/cocoon/servletservice/HttpServletResponseBufferingWrapper.java
That's an example of something that changed in r685544 which hasn't made it
into our DSpace SCM.
I've also noticed that there have been even more Cocoon fixes to the
HttpServletResponseBufferWrapper since that 'r685544', which we also may want
to apply in our version -- they all seem to be minor bug fixes to the larger
changes that were made in 'r685544'
http://svn.apache.org/viewvc/cocoon/trunk/subprojects/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/HttpServletResponseBufferingWrapper.java
> All XMLUI Error Pages respond with 200 OK, instead of 404 Not Found
> -------------------------------------------------------------------
>
> Key: DS-768
> URL: https://jira.duraspace.org/browse/DS-768
> Project: DSpace
> Issue Type: Bug
> Components: XMLUI
> Affects Versions: 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.8.0
> Reporter: Tim Donohue
> Assignee: Kim Shepherd
> Priority: Major
> Fix For: 1.8.0
>
> Attachments:
> add_ResourceNotFoundException_to_xmlui_transformers.patch,
> [DS-768]_add_ProcessingException_to_transformers,
> [DS-768]_dspace-cocoon-servlet-service-impl-1_0_2.patch,
> dspace-cocoon-servlet-service-impl-1.0.2.jar, Screen shot 2011-08-17 at
> 2.20.40 PM.png, Screenshot-Resource not found-Mozilla Firefox.png
>
>
> In DSpace 1.7.0 RC1, the XMLUI "Page Not Found" page responds with a 200 OK,
> rather than the necessary 404 Not Found error.
> For example:
> http://demo.dspace.org/xmlui/NOTAVALIDPATH
> I believe this used to function properly in 1.6.x, but it seems to be broken
> now.
> Obviously, we want this to return a 404 Not Found, in order to ensure that
> search engines do not index "Page Not Found" responses.
> Furthermore, it has been discovered that all other XMLUI Error pages (Cocoon
> Errors or Invalid Continuation errors) also respond with 200 OK. In
> addition, it seems this affects all 1.6.x versions of DSpace, as the same
> responses can be found on http://dspace.mit.edu (currently running 1.6.0 with
> patches), and http://researchspace.auckland.ac.nz (currently running 1.6.2
> with patches).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2d-oct
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
