On Sat, Aug 28, 2010 at 12:01 PM, Albin Tonnerre <[email protected]> wrote: > On Sat, 28 Aug 2010 09:30 -0300, Lucas De Marchi wrote : >> Hi all, >> >> See at http://people.profusion.mobi/~lucas/allparen.patch a patch I >> prepared for our svn using the scripts >> trunk/SCRIPTS/coccinelle/{paren,paren-or}.cocci >> >> I know this one is particular controversial (and bigger than I >> expected), so I'd like to hear from you whether it's worth applying to >> all projects or not. From what I discussed with raster on irc, it >> might be applied for EFL. > > I think this is generally a good idea. However, I have a little nitpick here. > While I can see the benefit of this change for non-trivial cases, I think it > should not be applied to the "trivial" cases, like: > > - if (widget && sd->context_menu) > + if ((widget) && (sd->context_menu))
What would be a non-trivial case? Cases where a '!' operator is involved? > > Is it possible to easily distinguish those cases from the cases > involving assignments/comparisons? Could you give examples of assignments / comparisons? Lucas De Marchi ------------------------------------------------------------------------------ Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook users worldwide. Take advantage of special opportunities to increase revenue and speed time-to-market. Join now, and jumpstart your future. http://p.sf.net/sfu/intel-atom-d2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
