> I have tested the new code block for AIX on version 5.1 (which lacks > the prototype for 'mntctl()' in the header file). > I have tested the code block for NetBSD on versions 2.0 and 5.1 to > check that the version detection works as intended (and old versions > that don't support 'getvfsstat()' behave as before).
OK, that sounds good; if you are feeling keen, might be worth recording those results in the STR in case anyone else is looking at it too? > > - The code doesn't seem to quite match the supposed fltk coding > style, see: > > http://www.fltk.org/cmp.php#CS_GENERAL_CODING_STYLE > > for more guidelines. > > (I confess this is often an issue for me, the fltk style is not my > default style...) > > Yes, the braces are not correctly placed. But this is wrong in many > other places of the current code inside 'Fl_File_Browser.cxx'. I noticed that, too... > To make it look consistent, should I repair this in the rest of the > file too? I don't really know, but my feeling is that we should make the minimal change, so that people can more easily see what has *actually* changed. So... in that case I'd propose that you leave the existing code, even where it is "wrong", but just try and make the new stuff be "right". Does that sound sensible? What do others think? > > - Is there a possibility that the AIX branch can call "free((void *) > list);" > > even if list has not been malloc'd? Would it be bad if it did? > > I have verified this before and initialized 'list' to NULL. > 'free(NULL)' > executes as NOP. This behaviour is required by POSIX and is documented > in the IBM manual page too: > http://pubs.opengroup.org/onlinepubs/7908799/xsh/free.html > http://www.ualberta.ca/dept/chemeng/AIX- > 43/share/man/info/C/a_doc_lib/libs/basetrf1/malloc.htm > My intention was to make it obvious that the memory is released in any > case. OK, agreed. > > - This is a nit-pick of mine, but I prefer: > > > > if (strcmp("/", filename) != 0) > > No problem, I will change this. As I say, it's a personal nit-pick of mine. I'd imagine the majority don’t' care either way! Cheers, -- Ian Selex ES Ltd Registered Office: Sigma House, Christopher Martin Road, Basildon, Essex SS14 3EL A company registered in England & Wales. Company no. 02426132 ******************************************************************** This email and any attachments are confidential to the intended recipient and may also be privileged. If you are not the intended recipient please delete it from your system and notify the sender. You should not copy it or use it for any purpose nor disclose or distribute its contents to any other person. ******************************************************************** _______________________________________________ fltk mailing list fltk@easysw.com http://lists.easysw.com/mailman/listinfo/fltk
