On Tue, Jan 10, 2012 at 03:28:25PM +0100, René Nussbaumer wrote: > On Tue, Jan 10, 2012 at 15:17, Iustin Pop <ius...@google.com> wrote: > > On Tue, Jan 10, 2012 at 11:46:50AM -0200, Michael Hanselmann wrote: > >> Am 10. Januar 2012 11:44 schrieb Guido Trotter <ultrot...@google.com>: > >> > I thought it was slightly different as "modify" for now only modifies > >> > config, not runtime. But I can change it to adding a flag there instead. > >> > >> Add it to “modify”. There are other flags for which it would be good > >> if they could be changed at runtime. > >> > >> > Can I still leave a gnt-instance set-mem command, calling that? It'll be > >> > easier to find. > >> > >> Maybe, but it's certainly more confusing. Consistency is very important. > > > > We don't want two commands that modify the memory. And especially not > > one top-level that is memory specific. > > I see that from the point of view how the instance is being left. If > the set-memory also modifies the value in the config when the instance > starts up next time, modify is the right place. For temporary effects > this might be confusing.
Hmm, right. But then I'd make it a different key (e.g. running-mem or such), but still in instance modify. iustin
