Thank you Carlo.  I updated the title on bug#128 and attached a final
patch which corrects the math in process_xml.c too.  This was needed to
get the total right in the summary graphs.

I cleaned up the code by removing the no longer needed integer addition.
This allows sources to be integers from 3.0 or floats from 3.1 and
correctly converts them both to double sums.  This would allow a smooth
transition to 3.1 over time.  Without this, folks would have to upgrade
all gmonds to 3.1 simultaneously or they would get incorrect totals.

-twitham

-----Original Message-----
From: Carlo Marcelo Arenas Belon [mailto:[EMAIL PROTECTED] 
Sent: Wednesday, March 19, 2008 2:07 AM
To: Witham, Timothy D
Cc: Brad Nicholes; [email protected]
Subject: Re: [Ganglia-developers] [Ganglia-general] Time to create
the3.1.xstable branch...

On Tue, Mar 18, 2008 at 12:11:44PM -0700, Witham, Timothy D wrote:
> Well, the patch I attached to bug#128 *does* convert all ints to
floats
> when doing sums, but it has not yet been applied to trunk as of 1078.

Part of it committed in revision 1083

> Maybe you need me to enter a new bug for exactly this issue; it seems
> like #128 has been abandoned.  But, the fix would still be similar.

Sorry if you though we abandoned your bug report, and thanks for the
fix.

Carlo

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Ganglia-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ganglia-developers

Reply via email to